Messages in this thread | ![/](/images/icornerl.gif) | | Date | Mon, 11 Dec 2023 11:16:10 -0800 | From | Dan Williams <> | Subject | Re: [PATCH 6/6] cxl/memdev: Register for and process CPER events |
| |
Ira Weiny wrote: > Dan Williams wrote: > > Ira Weiny wrote: > > > Dan Williams wrote: > > > > Ira Weiny wrote: > > > > > > > [snip] > > > > > > #define CXL_EVENT_HDR_FLAGS_REC_SEVERITY GENMASK(1, 0) > > > static void cxl_cper_event_call(struct cxl_cper_notifier_data *nd) > > > > Is struct cxl_cper_notifier_data needed anymore, just pass the record > > reference? > > I think so because the type of record is ID'ed by the GUID which is not > part of the common record. So the notifier data adds the cxl_event_type > enum.
Ah, yup, but then I wonder if CPER can just do the GUID to type enum lookup and keep the CXL side GUID-free? I.e. just pass the type as a separate argument.
| ![\](/images/icornerr.gif) |