lkml.org 
[lkml]   [2023]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 1/5] erofs: support I/O submission for sub-page compressed blocks
    From


    On 2023/12/6 17:10, Gao Xiang wrote:
    > Add a basic I/O submission path first to support sub-page blocks:
    >
    > - Temporary short-lived pages will be used entirely;
    >
    > - In-place I/O pages can be used partially, but compressed pages need
    > to be able to be mapped in contiguous virtual memory.
    >
    > As a start, currently cache decompression is explicitly disabled for
    > sub-page blocks, which will be supported in the future.
    >
    > Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>

    ...

    > + cur = mdev.m_pa;
    > + end = cur + pcl->pclusterpages << PAGE_SHIFT;

    In this patch, here should be
    end = cur + (pcl->pclusterpages << PAGE_SHIFT);

    but since this line will be immediately updated in the next patch
    as `end = cur + pcl->pclustersize;` so it will have no impact.
    I've fixed it up in the development tree.

    Thanks,
    Gao Xiang

    \
     
     \ /
      Last update: 2023-12-11 09:12    [W:5.157 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site