Messages in this thread | | | Date | Mon, 11 Dec 2023 16:10:51 +0800 | Subject | Re: [PATCH 1/5] erofs: support I/O submission for sub-page compressed blocks | From | Gao Xiang <> |
| |
On 2023/12/6 17:10, Gao Xiang wrote: > Add a basic I/O submission path first to support sub-page blocks: > > - Temporary short-lived pages will be used entirely; > > - In-place I/O pages can be used partially, but compressed pages need > to be able to be mapped in contiguous virtual memory. > > As a start, currently cache decompression is explicitly disabled for > sub-page blocks, which will be supported in the future. > > Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
...
> + cur = mdev.m_pa; > + end = cur + pcl->pclusterpages << PAGE_SHIFT;
In this patch, here should be end = cur + (pcl->pclusterpages << PAGE_SHIFT);
but since this line will be immediately updated in the next patch as `end = cur + pcl->pclustersize;` so it will have no impact. I've fixed it up in the development tree.
Thanks, Gao Xiang
| |