lkml.org 
[lkml]   [2023]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v6 5/5] selftests/mm: add UFFDIO_MOVE ioctl test
From
On 11.12.23 18:32, Mark Brown wrote:
> On Mon, Dec 11, 2023 at 05:53:59PM +0100, David Hildenbrand wrote:
>
>>>> (3) avoids dirtying the tree as a "make headers_install" would, but it also
>>>> means that each test that makes use of new uapi has to update the relevant
>>>> headers (what people working on QEMU are used to).
>
>>> Note that you can do an out of tree build to avoid dirtying things.
>
>> Yes, but apparently the simple "make headers_install" will dirty the kernel.
>
>> See (and ideally comment on)
>
>> https://lkml.kernel.org/r/20231209020144.244759-1-jhubbard@nvidia.com
>
> I mean, I guess people who don't want to install the headers are just
> not going to be able to build a bunch of tests? There definitely are a
> bunch of tests where it's not needed so I can see why people would not
> like being forced to do the headers step if they're only interested in
> those tests.

Yes. And before that, people mostly had no clue that headers had to be
installed in order to compile successfully.

So maybe a warning to give at least some hint might be reasonable.

--
Cheers,

David / dhildenb

\
 
 \ /
  Last update: 2023-12-11 19:01    [W:0.060 / U:1.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site