lkml.org 
[lkml]   [2023]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 12/14] ARM: dts: aspeed: yosemite4: add mctp config for NIC
From
On 11/12/2023 03:49, Delphine CC Chiu wrote:
> add mctp config for NIC
>
> Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>
> ---
> .../aspeed/aspeed-bmc-facebook-yosemite4.dts | 24 +++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> index 073f27f1e35f..c8e3a85b7a11 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> @@ -1273,40 +1273,64 @@ imux24: i2c@0 {
> #address-cells = <1>;
> #size-cells = <0>;
> reg = <0>;
> + mctp-controller;
> temperature-sensor@1f {
> compatible = "ti,tmp421";
> reg = <0x1f>;
> };
> +
> + emc1403@3c {

Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation


> + compatible = "smsc,emc1403";
> + reg = <0x3c>;
> + };
> };
>
> imux25: i2c@1 {
> #address-cells = <1>;
> #size-cells = <0>;
> reg = <1>;
> + mctp-controller;
> temperature-sensor@1f {
> compatible = "ti,tmp421";
> reg = <0x1f>;
> };
> +
> + emc1403@3c {

Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation



In other places as well.

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2023-12-11 09:07    [W:0.112 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site