Messages in this thread | | | From | Masahiro Yamada <> | Date | Tue, 12 Dec 2023 02:50:59 +0900 | Subject | Re: [PATCH v4] Add .editorconfig file for basic formatting |
| |
On Mon, Oct 23, 2023 at 3:26 PM Íñigo Huguet <ihuguet@redhat.com> wrote: > > On Mon, Oct 23, 2023 at 8:19 AM Vincent MAILHOL > <mailhol.vincent@wanadoo.fr> wrote: > > > > On Mon. 23 Oct. 2023 at 11:28, Jonathan Corbet <corbet@lwn.net> wrote: > > > Vincent MAILHOL <mailhol.vincent@wanadoo.fr> writes: > > > > > > > On Thu. 1 June 2023 at 16:53, Íñigo Huguet <ihuguet@redhat.com> wrote: > > > >> EditorConfig is a specification to define the most basic code formatting > > > >> stuff, and it's supported by many editors and IDEs, either directly or > > > >> via plugins, including VSCode/VSCodium, Vim, emacs and more. > > > >> > > > >> It allows to define formatting style related to indentation, charset, > > > >> end of lines and trailing whitespaces. It also allows to apply different > > > >> formats for different files based on wildcards, so for example it is > > > >> possible to apply different configs to *.{c,h}, *.py and *.rs. > > > >> > > > >> In linux project, defining a .editorconfig might help to those people > > > >> that work on different projects with different indentation styles, so > > > >> they cannot define a global style. Now they will directly see the > > > >> correct indentation on every fresh clone of the project. > > > >> > > > >> See https://editorconfig.org > > > >> > > > >> Co-developed-by: Danny Lin <danny@kdrag0n.dev> > > > >> Signed-off-by: Danny Lin <danny@kdrag0n.dev> > > > >> Signed-off-by: Íñigo Huguet <ihuguet@redhat.com> > > > >> --- > > > > > > > > Is there any news for this patch? I would really love this to become mainstream. > > > > > > I have concerns about this patch that I have expressed in the past. > > > > > > I'm not going to apply it... since it's a global change that affects all > > > kernel developers, I don't think I *should* apply it. I would recommend > > > sending it directly to Linus; if you can get an ack from him, I'll apply > > > it then. > > > > Hi Jonathan, > > > > Thanks for the comment, message taken. > > > > Hi Íñigo, > > > > The last version of the patch being from you, would you like to bring > > the topic to Linus yourself or shall I do it instead? > > I'm not doing kernel development lately, so please go ahead pushing > this if you want. > > Anyway, note that, as discussed in the thread, it is incorrect to say > that it will affect all kernel developers: most IDEs and editors only > have "opt-in" support for editorconfig, and the few that are not > "opt-in", are either "opt-out" or has a workaround (Kate).
Applied to linux-kbuild. Thanks.
We invested a significant amount of time in research and discussion, and I do not want to lose our efforts.
If it turns out to be problematic, it is easy to revert it. (although I do not think so, given the wide adoption in many projects.)
-- Best Regards Masahiro Yamada
| |