Messages in this thread | ![/](/images/icornerl.gif) | | From | Ji Sheng Teoh <> | Subject | Re: [PATCH v1 1/2] watchdog: starfive-wdt: Add JH8100 watchdog compatible string | Date | Tue, 12 Dec 2023 00:47:00 +0800 |
| |
On Mon, 11 Dec 2023 11:06:42 +0100 Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> On 09/12/2023 15:27, Ji Sheng Teoh wrote: > > Add "starfive,jh8100-wdt" compatible for StarFive's JH8100 watchdog. > > JH8100 watchdog reuses JH7110 register mapping. > > > > Signed-off-by: Ley Foon Tan <leyfoon.tan@starfivetech.com> > > Signed-off-by: Ji Sheng Teoh <jisheng.teoh@starfivetech.com> > > --- > > drivers/watchdog/starfive-wdt.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/watchdog/starfive-wdt.c > > b/drivers/watchdog/starfive-wdt.c index 5f501b41faf9..31785bb373d5 > > 100644 --- a/drivers/watchdog/starfive-wdt.c > > +++ b/drivers/watchdog/starfive-wdt.c > > @@ -581,6 +581,7 @@ static const struct dev_pm_ops > > starfive_wdt_pm_ops = { static const struct of_device_id > > starfive_wdt_match[] = { { .compatible = "starfive,jh7100-wdt", > > .data = &starfive_wdt_jh7100_variant }, { .compatible = > > "starfive,jh7110-wdt", .data = &starfive_wdt_jh7110_variant }, > > + { .compatible = "starfive,jh8100-wdt", .data = > > &starfive_wdt_jh7110_variant }, > > Device is compatible, so why not expressing it in the bindings and > dropping this change? > > Best regards, > Krzysztof >
Ok, will drop this change.
Thanks, Ji Sheng
| ![\](/images/icornerr.gif) |