Messages in this thread | | | Date | Sun, 10 Dec 2023 11:08:21 +0200 | Subject | Re: [PATCH 11/11] ASoC: SOF: topology: Add new DAI type entry for SOF_DAI_AMD_BT | From | Cristian Ciocaltea <> |
| |
On 12/10/23 05:30, Venkata Prasad Potturu wrote: > > On 12/10/23 02:23, Cristian Ciocaltea wrote: >> Commit efb931cdc4b9 ("ASoC: SOF: topology: Add support for AMD ACP >> DAIs") registered "ACP" name for SOF_DAI_AMD_BT DAI type. However, some >> boards, i.e. Steam Deck OLED, seem to require "ACPBT" for the same type: >> >> [ 467.489680] snd_sof_amd_vangogh 0000:04:00.5: ipc tx error for >> 0x30030000 (msg/reply size: 16/0): -22 >> [ 467.492775] snd_sof_amd_vangogh 0000:04:00.5: sof_ipc3_route_setup: >> route ACPBT2.IN -> BUF5.0 failed >> [ 467.495839] snd_sof_amd_vangogh 0000:04:00.5: >> sof_ipc3_set_up_all_pipelines: route set up failed >> [ 467.499128] snd_sof_amd_vangogh 0000:04:00.5: error: tplg component >> load failed -22 >> [ 467.502210] snd_sof_amd_vangogh 0000:04:00.5: error: failed to load >> DSP topology -22 >> [ 467.505289] snd_sof_amd_vangogh 0000:04:00.5: ASoC: error at >> snd_soc_component_probe on 0000:04:00.5: -22 >> [ 467.508430] sof_mach nau8821-max: ASoC: failed to instantiate card -22 >> [ 467.511725] sof_mach nau8821-max: error -EINVAL: Failed to register >> card(sof-nau8821-max) >> [ 467.514861] sof_mach: probe of nau8821-max failed with error -22 >> >> Add "ACPBT" alias for "ACP" SOF DAI type. >> >> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com> >> --- >> sound/soc/sof/topology.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/sound/soc/sof/topology.c b/sound/soc/sof/topology.c >> index e3e7fbe40fa6..73bf791e7520 100644 >> --- a/sound/soc/sof/topology.c >> +++ b/sound/soc/sof/topology.c >> @@ -290,6 +290,7 @@ static const struct sof_dai_types sof_dais[] = { >> {"SAI", SOF_DAI_IMX_SAI}, >> {"ESAI", SOF_DAI_IMX_ESAI}, >> {"ACP", SOF_DAI_AMD_BT}, >> + {"ACPBT", SOF_DAI_AMD_BT}, > No need to create the alias name, we can directly modify ACP to ACPBT as > ACP is not using anywhere.
Great, thanks, will do in v2.
>> {"ACPSP", SOF_DAI_AMD_SP}, >> {"ACPDMIC", SOF_DAI_AMD_DMIC}, >> {"ACPHS", SOF_DAI_AMD_HS},
| |