lkml.org 
[lkml]   [2023]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH net v3] tcp: Fix -Wc23-extensions in tcp_options_write()
    From
    On 11/6/23 21:34, Nathan Chancellor wrote:
    > On Mon, Nov 06, 2023 at 09:26:48PM +0000, Dmitry Safonov wrote:
    >> Seems like exactly the fix that my git testing tree had, with an
    >> exception to naming the helper tcp_ao_options_write().
    >
    > Heh, not sure why I never considered that as an option... I am guessing
    > it does not matter enough for a v4 at this point but I could send a
    > net-next change later to update it if you so desire!

    It doesn't matter really, not worth another patch :-)

    >> But then I found* your patch-v1 and decided not to send an alternative
    >> patch.
    >>
    >> Thanks for fixing this,
    >
    > Thanks for taking a look!
    >
    >> Reviewed-by: Dmitry Safonov <dima@arista.com>
    >>
    >> *had to fix my Gmail lkml filter to label not only emails with cc/to my
    >> name, but also the raw email address (usually, I got them to/cc "Dmitry
    >> Safonov", but this one didn't have the name and got lost in the lkml pile).
    >
    > Sorry about that, b4 used to have some interesting behavior around names
    > at one point (don't remember the details at the moment) and just using
    > emails avoided those issues. Maybe I should go back to names and emails
    > to see if I notice any problems again.

    No worries, should be fixed now. I preferred previously filtering by
    full name, rather than email address as I send patches from both work
    and home emails, but also sometimes people send patches/questions to
    emails from the companies I previously worked for, regardless .mailmap
    entries.

    Probably, they look for author in lkml/mail archive, rather than use git
    to get the current/proper email address.

    Thanks,
    Dmitry

    \
     
     \ /
      Last update: 2023-11-20 13:50    [W:2.446 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site