lkml.org 
[lkml]   [2023]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] regmap: add regmap_update_bits variant to autoshift mask
On Mon, Nov 06, 2023 at 05:34:06PM +0100, Brandon Cheo Fusi wrote:

> +static inline int regmap_update_bits_autoshift_val(struct regmap *map, unsigned int reg,
> + unsigned int mask, unsigned int val)
> +{

Really not a fan of the name here, and in any case if the shifting of
the value is an issue wouldn't this be a good case for using a field?

Please also add kunit testcases for new APIs.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2023-11-20 13:50    [W:0.036 / U:0.640 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site