| Date | Mon, 6 Nov 2023 15:24:30 +0100 | From | Peter Zijlstra <> | Subject | Re: [PATCH v5 5/7] sched/fair: Add trivial fair server |
| |
On Sat, Nov 04, 2023 at 11:59:22AM +0100, Daniel Bristot de Oliveira wrote:
> [ dl_server do not account for rt ]
> diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c > index 541d547e1019..1d7b96ca9011 100644 > --- a/kernel/sched/deadline.c > +++ b/kernel/sched/deadline.c > @@ -1382,6 +1382,13 @@ static void update_curr_dl_se(struct rq *rq, struct sched_dl_entity *dl_se, s64 > resched_curr(rq); > } > > + /* > + * The fair server (sole dl_server) does not account for real-time > + * workload because it is running fair work. > + */ > + if (dl_server(dl_se)) > + return; > + > /* > * Because -- for now -- we share the rt bandwidth, we need to > * account our runtime there too, otherwise actual rt tasks
Should we perhaps write this like so?
if (dl_se == &rq->fair_server) return;
|