lkml.org 
[lkml]   [2023]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 3/9] PCI: Drop pci_is_thunderbolt_attached()
    On Fri, 3 Nov 2023, Mario Limonciello wrote:

    > All callers have switched to dev_is_removable() for detecting
    > hotpluggable PCIe devices.
    >
    > Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
    > ---
    > include/linux/pci.h | 22 ----------------------
    > 1 file changed, 22 deletions(-)
    >
    > diff --git a/include/linux/pci.h b/include/linux/pci.h
    > index b56417276042..530b0a360514 100644
    > --- a/include/linux/pci.h
    > +++ b/include/linux/pci.h
    > @@ -2616,28 +2616,6 @@ static inline bool pci_ari_enabled(struct pci_bus *bus)
    > return bus->self && bus->self->ari_enabled;
    > }
    >
    > -/**
    > - * pci_is_thunderbolt_attached - whether device is on a Thunderbolt daisy chain
    > - * @pdev: PCI device to check
    > - *
    > - * Walk upwards from @pdev and check for each encountered bridge if it's part
    > - * of a Thunderbolt controller. Reaching the host bridge means @pdev is not
    > - * Thunderbolt-attached. (But rather soldered to the mainboard usually.)
    > - */
    > -static inline bool pci_is_thunderbolt_attached(struct pci_dev *pdev)
    > -{
    > - struct pci_dev *parent = pdev;
    > -
    > - if (pdev->is_thunderbolt)
    > - return true;
    > -
    > - while ((parent = pci_upstream_bridge(parent)))
    > - if (parent->is_thunderbolt)
    > - return true;
    > -
    > - return false;
    > -}
    > -
    > #if defined(CONFIG_PCIEPORTBUS) || defined(CONFIG_EEH)
    > void pci_uevent_ers(struct pci_dev *pdev, enum pci_ers_result err_type);
    > #endif
    >

    I don't think all callers have been removed. Ah, lkp has caught the same
    problem.

    --
    i.

    \
     
     \ /
      Last update: 2023-11-20 13:50    [W:6.356 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site