| From | jim.cromie@gmail ... | Date | Fri, 3 Nov 2023 21:05:55 -0600 | Subject | Re: [PATCH v1 10/12] dyndbg: add processing of T(race) flag argument |
| |
On Fri, Nov 3, 2023 at 7:10 AM Łukasz Bartosik <lb@semihalf.com> wrote: > > Add processing of argument provided to T(race) flag. > The argument value determines destination of debug logs: > > 0 - debug logs will be written to prdbg and devdbg trace events > [1..255] - debug logs will be written to trace instance > > A user can provide trace destination by folowing T flag with > ":" and trace destination value in range [0..255], for example: > > echo "module thunderbolt =pT:7" > /sys/kernel/debug/dynamic_debug/control > echo "module thunderbolt =lT:7,p" > /sys/kernel/debug/dynamic_debug/control > > When T flag with argument is followed by other flags then the next flag has > to be preceded with ",". >
the trailing , seems punctuation heavy. Could we just stipulate that any :string (leading : trailing anything) be the last flag in the spec ? bare T flags are not constrained otherwise. seems fine as API-spec-by-error-codes.
> When no value is provided trace destination defaults to 0, for example: > > echo "module thunderbolt =T" > /sys/kernel/debug/dynamic_debug/control > echo "module thunderbolt =lTp" > /sys/kernel/debug/dynamic_debug/control
no colon after T means p is a flag, not a destination name
|