lkml.org 
[lkml]   [2023]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v1 1/4] leds: trigger: gpio: Replace custom code for gpiod_get_optional()
    Date
    gpiod_get_optional() and currently used fwnode_gpiod_get_index()
    are both wrappers against the same engine internally. Since we
    have a pointer to struct device there is no reason to use fwnode
    type of GPIO call. So, replace the current fwnode call by respective
    gpiod ones.

    Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    ---
    drivers/leds/trigger/ledtrig-gpio.c | 7 +++----
    1 file changed, 3 insertions(+), 4 deletions(-)

    diff --git a/drivers/leds/trigger/ledtrig-gpio.c b/drivers/leds/trigger/ledtrig-gpio.c
    index 9b7fe5dd5208..d91ae7fde3cf 100644
    --- a/drivers/leds/trigger/ledtrig-gpio.c
    +++ b/drivers/leds/trigger/ledtrig-gpio.c
    @@ -89,10 +89,7 @@ static int gpio_trig_activate(struct led_classdev *led)
    * The generic property "trigger-sources" is followed,
    * and we hope that this is a GPIO.
    */
    - gpio_data->gpiod = fwnode_gpiod_get_index(dev->fwnode,
    - "trigger-sources",
    - 0, GPIOD_IN,
    - "led-trigger");
    + gpio_data->gpiod = gpiod_get_optional(dev, "trigger-sources", GPIOD_IN);
    if (IS_ERR(gpio_data->gpiod)) {
    ret = PTR_ERR(gpio_data->gpiod);
    kfree(gpio_data);
    @@ -104,6 +101,8 @@ static int gpio_trig_activate(struct led_classdev *led)
    return -EINVAL;
    }

    + gpiod_set_consumer_name(gpio_data->gpiod, "led-trigger");
    +
    gpio_data->led = led;
    led_set_trigger_data(led, gpio_data);

    --
    2.40.0.1.gaa8946217a0b
    \
     
     \ /
      Last update: 2023-11-20 13:48    [W:2.886 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site