lkml.org 
[lkml]   [2023]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v7 08/10] arm64: Kconfig.platforms: Add config for Marvell PXA1908 platform
From
On 2023-11-02 3:20 pm, Duje Mihanović wrote:
> Add ARCH_MMP configuration option for Marvell PXA1908 SoC.
>
> Signed-off-by: Duje Mihanović <duje.mihanovic@skole.hr>
> ---
> arch/arm64/Kconfig.platforms | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> index 6069120199bb..b417cae42c84 100644
> --- a/arch/arm64/Kconfig.platforms
> +++ b/arch/arm64/Kconfig.platforms
> @@ -89,6 +89,17 @@ config ARCH_BERLIN
> help
> This enables support for Marvell Berlin SoC Family
>
> +config ARCH_MMP
> + bool "Marvell MMP SoC Family"
> + select ARM_GIC
> + select ARM_ARCH_TIMER
> + select ARM_SMMU

NAK, not only is selecting user-visible symbols generally frowned upon,
and ignoring their dependencies even worse, but for a multiplatform
kernel the user may well want this to be a module.

If having the SMMU driver built-in is somehow fundamentally required for
this platform to boot, that would represent much bigger problems.

Thanks,
Robin.

> + select MMP_PDMA
> + select PINCTRL_SINGLE
> + help
> + This enables support for Marvell MMP SoC family, currently
> + supporting PXA1908 aka IAP140.
> +
> config ARCH_BITMAIN
> bool "Bitmain SoC Platforms"
> help

\
 
 \ /
  Last update: 2023-11-20 13:48    [W:0.077 / U:0.384 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site