lkml.org 
[lkml]   [2023]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] nvme: update firmware version after commit
On Fri, Nov 03, 2023 at 01:11:02PM +0100, Daniel Wagner wrote:
> This particular firmware seem to interpret afi one based, while
> the this patch assumes it is zero based

> Active Firmware Info (AFI): Specifies information about the active
> firmware revision.
>
> Bit 7 is reserved.
> Bits 6:4 indicates the firmware slot that is going to be activated
> at the next Controller Level Reset. If this field is 0h,
> then the controller does not indicate the firmware slot that
> is going to be activated at the next Controller Level Reset.
> Bit 3 is reserved.
> Bits 2:0 indicates the firmware slot from which the actively running
> firmware revision was loaded.
>
>
> It's not clear to me if afi bits 2:0 is zero or one based. Bits 6:4
> indicate to be 1 based.

All 0's based (what a stupid term..) fields in NVMe are explicitly
marked as such. And even if that wasn't the case I'd very much
expect the same encoding for the two sub-fields.

\
 
 \ /
  Last update: 2023-11-20 13:47    [W:0.757 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site