lkml.org 
[lkml]   [2023]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH V2 5/6] mmc: cqhci: Warn of halt or task clear failure
Date
> A correctly operating controller should successfully halt and clear tasks.
> Failure may result in errors elsewhere, so promote messages from debug to
> warnings.
>
> Fixes: a4080225f51d ("mmc: cqhci: support for command queue enabled
> host")
> Cc: stable@vger.kernel.org
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Reviewed-by: Avri Altman <avri.altman@wdc.com>

> ---
> drivers/mmc/host/cqhci-core.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/host/cqhci-core.c b/drivers/mmc/host/cqhci-core.c
> index 15f5a069af1f..948799a0980c 100644
> --- a/drivers/mmc/host/cqhci-core.c
> +++ b/drivers/mmc/host/cqhci-core.c
> @@ -942,8 +942,8 @@ static bool cqhci_clear_all_tasks(struct mmc_host
> *mmc, unsigned int timeout)
> ret = cqhci_tasks_cleared(cq_host);
>
> if (!ret)
> - pr_debug("%s: cqhci: Failed to clear tasks\n",
> - mmc_hostname(mmc));
> + pr_warn("%s: cqhci: Failed to clear tasks\n",
> + mmc_hostname(mmc));
>
> return ret;
> }
> @@ -976,7 +976,7 @@ static bool cqhci_halt(struct mmc_host *mmc,
> unsigned int timeout)
> ret = cqhci_halted(cq_host);
>
> if (!ret)
> - pr_debug("%s: cqhci: Failed to halt\n", mmc_hostname(mmc));
> + pr_warn("%s: cqhci: Failed to halt\n",
> + mmc_hostname(mmc));
>
> return ret;
> }
> --
> 2.34.1

\
 
 \ /
  Last update: 2023-11-20 13:47    [W:0.146 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site