Messages in this thread | | | Date | Fri, 3 Nov 2023 06:53:29 +0100 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH] drivers/comedi: copy userspace array safely |
| |
On Thu, Nov 02, 2023 at 08:08:49PM +0100, Philipp Stanner wrote: > comedi_fops.c utilizes memdup_user() to copy a userspace array. This > does not check for an overflow.
Is there potential for an overflow today?
> > Use the new wrapper memdup_array_user() to copy the array more safely.
How about saying something like: "Use the new function memdup_array_user() in case things change in the future which would prevent overflows if something were to change in the size of the structures".
Or something to the affect of "all is good today, but make it easy to be correct in the future as well".
thanks,
greg k-h
| |