Messages in this thread | | | Date | Wed, 22 Nov 2023 16:15:21 +0100 | From | Tommaso Merciai <> | Subject | Re: [PATCH 2/2] media: rkisp1: Fix memory leaks in rkisp1_isp_unregister() |
| |
Hi Tomi,
On Wed, Nov 22, 2023 at 04:42:23PM +0200, Tomi Valkeinen wrote: > Add missing call to v4l2_subdev_cleanup() to fix memory leak. > > Fixes: 2cce0a369dbd ("media: rkisp1: isp: Use V4L2 subdev active state") > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> > --- > drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c > index 88ca8b2283b7..45d1ab96fc6e 100644 > --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c > +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c > @@ -933,6 +933,7 @@ void rkisp1_isp_unregister(struct rkisp1_device *rkisp1) > return; > > v4l2_device_unregister_subdev(&isp->sd); > + v4l2_subdev_cleanup(&isp->sd); > media_entity_cleanup(&isp->sd.entity); > } > > > -- > 2.34.1 > >
Reviewed-by: Tommaso Merciai <tomm.merciai@gmail.com>
Thanks & Regards, Tommaso
| |