Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 22 Nov 2023 09:41:06 +0100 | Subject | Re: [PATCH v2 6/6] arm64: dts: amlogic: migrate pwms to new meson8 v2 binding | From | Krzysztof Kozlowski <> |
| |
On 17/11/2023 13:59, Jerome Brunet wrote: > Update Amlogic based SoC PWMs to meson8-pwm-v2 compatible
Please write proper commit msgs.
> > Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
...
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gx-p23x-q20x.dtsi b/arch/arm64/boot/dts/amlogic/meson-gx-p23x-q20x.dtsi > index 18f7b730289e..690552e5a104 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-gx-p23x-q20x.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-gx-p23x-q20x.dtsi > @@ -237,8 +237,6 @@ &pwm_ef { > status = "okay"; > pinctrl-0 = <&pwm_e_pins>; > pinctrl-names = "default"; > - clocks = <&clkc CLKID_FCLK_DIV4>; > - clock-names = "clkin0"; > }; > > &saradc { > diff --git a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi > index 2673f0dbafe7..bf00672b9009 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi > @@ -329,14 +329,14 @@ i2c_A: i2c@8500 { > }; > > pwm_ab: pwm@8550 { > - compatible = "amlogic,meson-gx-pwm", "amlogic,meson-gxbb-pwm"; > + compatible = "amlogic,meson8-pwm-v2";
This is just wrong. NAK.
Replacing specific and correct (nothing in commit msg said these are incorrect!) compatibles with generic, unspecific one is a no-go. It does not make sense to replace correct code with incorrect...
Best regards, Krzysztof
| ![\](/images/icornerr.gif) |