lkml.org 
[lkml]   [2023]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] iommu/amd: Set variable amd_dirty_ops to static
    From
    On 20/11/2023 09:53, Kunwu Chan wrote:
    > Fix the followng warning:
    > drivers/iommu/amd/iommu.c:67:30: warning: symbol
    > 'amd_dirty_ops' was not declared. Should it be static?
    >
    > This variable is only used in its defining file, so it should be static.
    >
    > Signed-off-by: Kunwu Chan <chentao@kylinos.cn>

    Reviewed-by: Joao Martins <joao.m.martins@oracle.com>

    > ---
    > drivers/iommu/amd/iommu.c | 4 ++--
    > 1 file changed, 2 insertions(+), 2 deletions(-)
    >
    > diff --git a/drivers/iommu/amd/iommu.c b/drivers/iommu/amd/iommu.c
    > index fcc987f5d4ed..9f7064360828 100644
    > --- a/drivers/iommu/amd/iommu.c
    > +++ b/drivers/iommu/amd/iommu.c
    > @@ -64,7 +64,7 @@ LIST_HEAD(hpet_map);
    > LIST_HEAD(acpihid_map);
    >
    > const struct iommu_ops amd_iommu_ops;
    > -const struct iommu_dirty_ops amd_dirty_ops;
    > +static const struct iommu_dirty_ops amd_dirty_ops;
    >
    > int amd_iommu_max_glx_val = -1;
    >
    > @@ -2635,7 +2635,7 @@ static bool amd_iommu_enforce_cache_coherency(struct iommu_domain *domain)
    > return true;
    > }
    >
    > -const struct iommu_dirty_ops amd_dirty_ops = {
    > +static const struct iommu_dirty_ops amd_dirty_ops = {
    > .set_dirty_tracking = amd_iommu_set_dirty_tracking,
    > .read_and_clear_dirty = amd_iommu_read_and_clear_dirty,
    > };

    \
     
     \ /
      Last update: 2023-11-21 11:05    [W:2.375 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site