Messages in this thread | | | Date | Tue, 21 Nov 2023 10:17:00 +0100 | Subject | Re: [PATCH] gpu: display: remove unnecessary braces to fix coding style | From | Christian König <> |
| |
Am 21.11.23 um 05:36 schrieb RutingZhang: > checkpatch complains that: > > WARNING: braces {} are not necessary for single statement blocks > + if (pool->base.irqs != NULL) { > + dal_irq_service_destroy(&pool->base.irqs); > + } > > Fixed it by removing unnecessary braces to fix the coding style issue. > > Signed-off-by: RutingZhang <u202112078@hust.edu.cn> > Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn>
Subject line prefix should be "drm/amdgpu".
Apart from this nit it looks good to me, but might be already fixed internally.
Regards, Christian.
> --- > drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c b/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c > index 447de8492594..6835dbb733a2 100644 > --- a/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c > +++ b/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c > @@ -713,9 +713,8 @@ static void dcn21_resource_destruct(struct dcn21_resource_pool *pool) > pool->base.hubps[i] = NULL; > } > > - if (pool->base.irqs != NULL) { > + if (pool->base.irqs != NULL) > dal_irq_service_destroy(&pool->base.irqs); > - } > } > > for (i = 0; i < pool->base.res_cap->num_ddc; i++) {
| |