Messages in this thread | | | Date | Tue, 21 Nov 2023 10:04:45 +0100 | Subject | Re: [PATCH 1/6] dt-bindings: crypto: add support for rockchip,crypto-rk3588 | From | Krzysztof Kozlowski <> |
| |
On 20/11/2023 13:37, Corentin LABBE wrote:
>>> diff --git a/Documentation/devicetree/bindings/crypto/rockchip,rk3588-crypto.yaml b/Documentation/devicetree/bindings/crypto/rockchip,rk3588-crypto.yaml >>> new file mode 100644 >>> index 000000000000..07024cf4fb0e >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/crypto/rockchip,rk3588-crypto.yaml >>> @@ -0,0 +1,65 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/crypto/rockchip,rk3588-crypto.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Rockchip cryptographic offloader V2 >> >> v2? Where is any documentation of this versioning? From where does it >> come from? >> > > Hello > > Datasheet/TRM has no naming or codename. > But vendor source call it crypto v2, so I kept the name.
I would suggest using information from datasheet/manual or just SoC name, so:
Rockchip RK3588 Cryptographic Offloader
How can you be sure that downstream source used v2 for hardware, not driver? Poor-quality downstream source is rarely a source of proper solution...
Best regards, Krzysztof
| |