Messages in this thread | | | Date | Tue, 21 Nov 2023 09:31:13 +0100 | Subject | Re: [PATCH v3 1/3] dt-bindings: connector: usb: add altmodes description | From | Krzysztof Kozlowski <> |
| |
On 20/11/2023 23:00, Dmitry Baryshkov wrote: > Add description of the USB-C AltModes supported on the particular USB-C > connector. This is required for devices like Qualcomm Robotics RB5, > which have no other way to express alternative modes supported by the > hardware platform. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > .../bindings/connector/usb-connector.yaml | 29 +++++++++++++++++++ > 1 file changed, 29 insertions(+) > > diff --git a/Documentation/devicetree/bindings/connector/usb-connector.yaml b/Documentation/devicetree/bindings/connector/usb-connector.yaml > index 7c8a3e8430d3..c1aaac861d9d 100644 > --- a/Documentation/devicetree/bindings/connector/usb-connector.yaml > +++ b/Documentation/devicetree/bindings/connector/usb-connector.yaml > @@ -171,6 +171,28 @@ properties: > offer the power, Capability Mismatch is set. Required for power sink and > power dual role. > > + altmodes: > + type: object > + description: List of Alternative Modes supported by the schematics on the > + particular device. This is only necessary if there are no other means to > + discover supported alternative modes (e.g. through the UCSI firmware > + interface). > + > + patternProperties: > + "^(displayport)$":
This is just a property, so should be under "properties:".
The rest looks good to me, but I don't know USB that much to judge.
Best regards, Krzysztof
| |