Messages in this thread | | | Date | Tue, 21 Nov 2023 21:36:13 +0100 | From | Andrew Lunn <> | Subject | Re: [PATCH] net: stmmac: fix out-of-bounds read via memcpy detected by KASAN |
| |
> > q0_tx_irq_n: 4 > > q0_rx_pkt_n: 64 > > q0_rx_irq_n: 58 > > What useful information does this list of statistics bring in the > commit message? > > Each output line of "ethtool -S" is from the modified code: It shows the > command still yields normal output results as expected.
Does it? Can you actually say that looking at it?
> No, since strscpy does the job already. Also I could not find ethtool_puts: > where is it defined? Or do you mean ethtool_put_stat, which is inappropriate to > use here since it requires a skb parameter?
https://patchwork.kernel.org/project/netdevbpf/patch/20231102-ethtool_puts_impl-v4-3-14e1e9278496@google.com/
Maybe check with Justin when we will resend that patch.
Andrew
| |