Messages in this thread | | | From | Namhyung Kim <> | Date | Tue, 21 Nov 2023 10:21:36 -0800 | Subject | Re: [PATCH 1/3] perf/core: Update perf_adjust_freq_unthr_context() |
| |
Hi Mingwei,
On Mon, Nov 20, 2023 at 3:24 PM Mingwei Zhang <mizhang@google.com> wrote: > > On Mon, Nov 20, 2023, Ian Rogers wrote: > > On Mon, Nov 20, 2023 at 2:19 PM Namhyung Kim <namhyung@kernel.org> wrote: > > > > > > It was unnecessarily disabling and enabling PMUs for each event. It > > > should be done at PMU level. Add pmu_ctx->nr_freq counter to check it > > > at each PMU. As pmu context has separate active lists for pinned group > > > and flexible group, factor out a new function to do the job. > > > > > > Another minor optimization is that it can skip PMUs w/ CAP_NO_INTERRUPT > > > even if it needs to unthrottle sampling events. > > > > > > Signed-off-by: Namhyung Kim <namhyung@kernel.org> > > > > Series: > > Reviewed-by: Ian Rogers <irogers@google.com> > > > > Thanks, > > Ian > > > > Can we have "Cc: stable@vger.kernel.org" for the whole series? This > series should have a great performance improvement for all VMs in which > perf sampling events without specifying period.
I was not sure if it's ok to have this performance fix in the stable series.
Thanks, Namhyung
| |