Messages in this thread | | | Date | Mon, 20 Nov 2023 09:55:22 +0000 | From | Charles Keepax <> | Subject | Re: [PATCH 6/7] ASoC: cs43130: Allow driver to work without IRQ thread |
| |
On Mon, Nov 20, 2023 at 09:43:25AM +0000, Maciej Strozek wrote: > W dniu pią, 17.11.2023 o godzinie 16∶36 +0000, użytkownik Mark Brown > napisał: > > On Fri, Nov 17, 2023 at 02:13:43PM +0000, Maciej Strozek wrote: > > > Signed-off-by: Maciej Strozek <mstrozek@opensource.cirrus.com> > > > --- > > > sound/soc/codecs/cs43130.c | 56 +++++++++++++++++++++++++++++++--- > > > ---- > > > sound/soc/codecs/cs43130.h | 1 + > > > 2 files changed, 47 insertions(+), 10 deletions(-) > > > > Why? This isn't some obvious fix, you need to write a changelog > > motivating open coding interrupt handling if there's some reason for > > doing that. > > This is to support systems without physical IRQ connection. The device > only requires the IRQ for a couple of internal delays, this polling > mechanism is a fallback when no IRQ is specified. >
Yeah pop that in the change log and resend the patch as a v2.
Thanks, Charles
| |