lkml.org 
[lkml]   [2023]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [net-next PATCH] net: phy: correctly check soft_reset ret ONLY if defined for PHY
On Mon, Nov 20, 2023 at 09:42:34AM -0800, Jakub Kicinski wrote:
> On Mon, 20 Nov 2023 14:15:40 +0100 Christian Marangi wrote:
> > Luckly nothing was ever added before the soft_reset call so the ret
> > check (in the case where a PHY didn't had soft_reset defined) although
> > wrong, never caused problems as ret was init 0 at the start of
> > phy_init_hw.
>
> not currently a bug => no Fixes tag, please

I know it's not a bug but still the referenced commit was wrong. Can I
at least use Ref to reference it?

Due to the changes done to this function, it's hard to catch where the
problem arised with a git blame.

--
Ansuel

\
 
 \ /
  Last update: 2023-11-20 20:48    [W:0.043 / U:0.916 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site