Messages in this thread | | | Subject | Re: [PATCH] misc: ocxl: main: Remove unnecessary ‘0’ values from rc | From | Andrew Donnellan <> | Date | Mon, 20 Nov 2023 15:19:31 +1100 |
| |
On Mon, 2023-11-13 at 09:52 +0800, Li kunyu wrote: > rc is assigned first, so it does not need to initialize the > assignment. > > Signed-off-by: Li kunyu <kunyu@nfschina.com>
I don't have strong feelings about whether to get rid of unnecessary initialisations, but most of the code doesn't do it, so for consistency:
Acked-by: Andrew Donnellan <ajd@linux.ibm.com>
> --- > drivers/misc/ocxl/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/misc/ocxl/main.c b/drivers/misc/ocxl/main.c > index ef73cf35dda2b..658974143c3cc 100644 > --- a/drivers/misc/ocxl/main.c > +++ b/drivers/misc/ocxl/main.c > @@ -7,7 +7,7 @@ > > static int __init init_ocxl(void) > { > - int rc = 0; > + int rc; > > if (!tlbie_capable) > return -EINVAL;
-- Andrew Donnellan OzLabs, ADL Canberra ajd@linux.ibm.com IBM Australia Limited
| |