lkml.org 
[lkml]   [2023]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 1/4] dt-bindings: reset: Add binding for Sophgo CV1800B reset controller
    From
    On 13/11/2023 01:55, Jisheng Zhang wrote:
    ...

    > diff --git a/include/dt-bindings/reset/sophgo,cv1800b-reset.h b/include/dt-bindings/reset/sophgo,cv1800b-reset.h
    > new file mode 100644
    > index 000000000000..28dda71369b4
    > --- /dev/null
    > +++ b/include/dt-bindings/reset/sophgo,cv1800b-reset.h
    > @@ -0,0 +1,96 @@
    > +/* SPDX-License-Identifier: GPL-2.0 OR MIT */
    > +/*
    > + * Copyright (C) 2023 Sophgo Technology Inc. All rights reserved.
    > + * Copyright (C) 2023 Jisheng Zhang <jszhang@kernel.org>
    > + */
    > +
    > +#ifndef _DT_BINDINGS_CV1800B_RESET_H
    > +#define _DT_BINDINGS_CV1800B_RESET_H
    > +
    > +/* 0-1 */
    > +#define RST_DDR 2
    > +#define RST_H264C 3
    > +#define RST_JPEG 4
    > +#define RST_H265C 5
    > +#define RST_VIPSYS 6
    > +#define RST_TDMA 7
    > +#define RST_TPU 8
    > +#define RST_TPUSYS 9
    > +/* 10 */

    Why do you have empty IDs? IDs start at 0 and are incremented by 1.

    Best regards,
    Krzysztof

    \
     
     \ /
      Last update: 2023-11-20 13:59    [W:3.674 / U:0.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site