Messages in this thread | | | Date | Tue, 14 Nov 2023 21:29:58 +0100 | Subject | Re: [PATCH v2 1/4] dt-bindings: iio: adc: ad7192: Add properties | From | Krzysztof Kozlowski <> |
| |
On 14/11/2023 21:05, Alisa-Dariana Roman wrote: > Document properties used for clock configuration.
Some background here is missing - otherwise it looks like you are adding new properties...
> > Signed-off-by: Alisa-Dariana Roman <alisa.roman@analog.com> > --- > .../devicetree/bindings/iio/adc/adi,ad7192.yaml | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml > index 16def2985ab4..9b59d6eea368 100644 > --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml > +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml > @@ -80,6 +80,16 @@ properties: > and when chop is disabled. > type: boolean > > + adi,clock-xtal: > + description: | > + External crystal connected from MCLK1 to MCLK2.
And this should be input clock.
> + type: boolean > + > + adi,int-clock-output-enable: > + description: | > + Internal 4.92 MHz clock available on MCLK2 pin. > + type: boolean
This should be clock-cells and clock provider.
Unless you are just documenting already used interface which you do not want to break...
> + > bipolar: > description: see Documentation/devicetree/bindings/iio/adc/adc.yaml > type: boolean
Best regards, Krzysztof
| |