Messages in this thread | | | Date | Tue, 14 Nov 2023 21:11:46 +0100 | Subject | Re: [PATCH 01/20] mm/slab: remove CONFIG_SLAB from all Kconfig and Makefile | From | Vlastimil Babka <> |
| |
On 11/14/23 05:11, Kees Cook wrote: > On Mon, Nov 13, 2023 at 08:13:42PM +0100, Vlastimil Babka wrote: >> Remove CONFIG_SLAB, CONFIG_DEBUG_SLAB, CONFIG_SLAB_DEPRECATED and >> everything in Kconfig files and mm/Makefile that depends on those. Since >> SLUB is the only remaining allocator, remove the allocator choice, make >> CONFIG_SLUB a "def_bool y" for now and remove all explicit dependencies >> on SLUB as it's now always enabled. >> >> Everything under #ifdef CONFIG_SLAB, and mm/slab.c is now dead code, all >> code under #ifdef CONFIG_SLUB is now always compiled. >> >> Signed-off-by: Vlastimil Babka <vbabka@suse.cz> >> [...] >> diff --git a/mm/Kconfig b/mm/Kconfig >> index 89971a894b60..766aa8f8e553 100644 >> --- a/mm/Kconfig >> +++ b/mm/Kconfig >> @@ -228,47 +228,12 @@ config ZSMALLOC_CHAIN_SIZE >> >> menu "SLAB allocator options" > > Should this be "Slab allocator options" ? (I've always understood > "slab" to mean the general idea, and "SLAB" to mean the particular > implementation.
Good point, will change
> Regardless: > > Reviewed-by: Kees Cook <keescook@chromium.org>
Thanks!
| |