Messages in this thread | | | Date | Tue, 14 Nov 2023 20:20:19 +0100 | From | Andrew Lunn <> | Subject | Re: [PATCH net-next v3 6/8] net: phy: add calibration callbacks to phy_driver |
| |
On Tue, Nov 14, 2023 at 11:55:56AM +0100, Romain Gantois wrote: > The IPQESS integrated Ethernet switch found in the IPQ4019 SoC requires > calibration of the PHY link when its ports are brought up. This calibration > procedure requires knowledge of precise timings and vendor-specific > registers on both the PHY and MAC side. > > The existing PHY abstraction layer does not allow coordinating this kind of > calibration operation between MAC drivers and PHY drivers. As a > consequence, PHY-specific calibration information has to be included in > Ethernet drivers, since it has to schedule the entire calibration procedure > on it's own. > > Add two callbacks that extend the PHY abstraction layer to allow MAC > drivers to start and stop PHY calibration runs in a PHY-model-independent > manner.
When adding new APIs, you need to add an example of both sides of it. We can then decide if the API makes sense. I don't see a PHY driver implementing this API.
Andrew
--- pw-bot: cr
| |