Messages in this thread | | | Date | Tue, 14 Nov 2023 11:46:46 -0600 | From | Lucas De Marchi <> | Subject | Re: [PATCH] iosys-map: Rename locals used inside macros |
| |
On Tue, Oct 24, 2023 at 08:10:32AM -0500, Lucas De Marchi wrote: >On Tue, Oct 24, 2023 at 01:07:10PM +0200, Michał Winiarski wrote: >>Widely used variable names can be used by macro users, potentially >>leading to name collisions. >>Suffix locals used inside the macros with an underscore, to reduce the >>collision potential. >> >>Suggested-by: Lucas De Marchi <lucas.demarchi@intel.com> >>Signed-off-by: Michał Winiarski <michal.winiarski@intel.com> > >`git show --color-words` shows this is doing exactly what it should. > >Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
applied to drm-misc-next. Thanks
Lucas De Marchi
> >Maybe note in the commit message the compilation error we get with >clang? Although that's in the xe driver that is still not merged >upstream... so not really required. > >thanks >Lucas De Marchi
| |