Messages in this thread | | | From | Oleksandr Tyshchenko <> | Subject | Re: [PATCH 6/7] xen/events: modify internal [un]bind interfaces | Date | Tue, 14 Nov 2023 13:45:02 +0000 |
| |
On 16.10.23 09:28, Juergen Gross wrote:
Hello Juergen
> Modify the internal bind- and unbind-interfaces to take a struct > irq_info parameter. When allocating a new IRQ pass the pointer from > the allocating function further up. > > This will reduce the number of info_for_irq() calls and make the code > more efficient. > > Signed-off-by: Juergen Gross <jgross@suse.com>
I didn't spot obvious issues with current patch, other than just the fact that patch needs rebasing (some hunks cannot be applied because of "e64e7c74b99e xen/events: avoid using info_for_irq() in xen_send_IPI_one()" went in).
I was going to ask why "pirq_query_unmask()/pirq_from_irq()" wasn't converted to take a struct irq_info parameter as well, but looking at the rest I noticed this was already done in subsequent commit.
With proper rebasing: Reviewed-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
[snip]
| |