lkml.org 
[lkml]   [2023]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH 1/8] dt-bindings: phy: mediatek,xfi-pextp: add new bindings
On Thu, Nov 09, 2023 at 11:11:02PM +0000, Daniel Golle wrote:
> Hi Andrew,
>
> On Thu, Nov 09, 2023 at 10:55:55PM +0100, Andrew Lunn wrote:
> > > + mediatek,usxgmii-performance-errata:
> > > + $ref: /schemas/types.yaml#/definitions/flag
> > > + description:
> > > + USXGMII0 on MT7988 suffers from a performance problem in 10GBase-R
> > > + mode which needs a work-around in the driver. The work-around is
> > > + enabled using this flag.
> >
> > Is there more details about this? I'm just wondering if this should be
> > based on the compatible, rather than a bool property.
>
> The vendor sources where this is coming from are here:
>
> https://git01.mediatek.com/plugins/gitiles/openwrt/feeds/mtk-openwrt-feeds/+/a500d94cd47e279015ce22947e1ce396a7516598%5E%21/#F0
>
> And I'm afraid this is as much detail as it gets. And yes, we could
> also base this on the compatible and just have two different ones for
> the two PEXTP instances found in MT7988.
> Let me know your conclusion in that regard.

I'd go with a property in this case unless you think there may be other
per instance differences.

Rob

\
 
 \ /
  Last update: 2023-11-20 13:59    [W:0.305 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site