lkml.org 
[lkml]   [2023]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] misc: ocxl: link: Remove unnecessary (void*) conversions
From


On 13/11/2023 02:45, Li zeming wrote:
> The link pointer does not need to cast the type.
>
> Signed-off-by: Li zeming <zeming@nfschina.com>
> ---


Acked-by: Frederic Barrat <fbarrat@linux.ibm.com>

Fred


> drivers/misc/ocxl/link.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/misc/ocxl/link.c b/drivers/misc/ocxl/link.c
> index c06c699c0e7b1..03402203cacdb 100644
> --- a/drivers/misc/ocxl/link.c
> +++ b/drivers/misc/ocxl/link.c
> @@ -188,7 +188,7 @@ static void xsl_fault_handler_bh(struct work_struct *fault_work)
>
> static irqreturn_t xsl_fault_handler(int irq, void *data)
> {
> - struct ocxl_link *link = (struct ocxl_link *) data;
> + struct ocxl_link *link = data;
> struct spa *spa = link->spa;
> u64 dsisr, dar, pe_handle;
> struct pe_data *pe_data;
> @@ -483,7 +483,7 @@ static void release_xsl(struct kref *ref)
>
> void ocxl_link_release(struct pci_dev *dev, void *link_handle)
> {
> - struct ocxl_link *link = (struct ocxl_link *) link_handle;
> + struct ocxl_link *link = link_handle;
>
> mutex_lock(&links_list_lock);
> kref_put(&link->ref, release_xsl);
> @@ -540,7 +540,7 @@ int ocxl_link_add_pe(void *link_handle, int pasid, u32 pidr, u32 tidr,
> void (*xsl_err_cb)(void *data, u64 addr, u64 dsisr),
> void *xsl_err_data)
> {
> - struct ocxl_link *link = (struct ocxl_link *) link_handle;
> + struct ocxl_link *link = link_handle;
> struct spa *spa = link->spa;
> struct ocxl_process_element *pe;
> int pe_handle, rc = 0;
> @@ -630,7 +630,7 @@ EXPORT_SYMBOL_GPL(ocxl_link_add_pe);
>
> int ocxl_link_update_pe(void *link_handle, int pasid, __u16 tid)
> {
> - struct ocxl_link *link = (struct ocxl_link *) link_handle;
> + struct ocxl_link *link = link_handle;
> struct spa *spa = link->spa;
> struct ocxl_process_element *pe;
> int pe_handle, rc;
> @@ -666,7 +666,7 @@ int ocxl_link_update_pe(void *link_handle, int pasid, __u16 tid)
>
> int ocxl_link_remove_pe(void *link_handle, int pasid)
> {
> - struct ocxl_link *link = (struct ocxl_link *) link_handle;
> + struct ocxl_link *link = link_handle;
> struct spa *spa = link->spa;
> struct ocxl_process_element *pe;
> struct pe_data *pe_data;
> @@ -752,7 +752,7 @@ EXPORT_SYMBOL_GPL(ocxl_link_remove_pe);
>
> int ocxl_link_irq_alloc(void *link_handle, int *hw_irq)
> {
> - struct ocxl_link *link = (struct ocxl_link *) link_handle;
> + struct ocxl_link *link = link_handle;
> int irq;
>
> if (atomic_dec_if_positive(&link->irq_available) < 0)
> @@ -771,7 +771,7 @@ EXPORT_SYMBOL_GPL(ocxl_link_irq_alloc);
>
> void ocxl_link_free_irq(void *link_handle, int hw_irq)
> {
> - struct ocxl_link *link = (struct ocxl_link *) link_handle;
> + struct ocxl_link *link = link_handle;
>
> xive_native_free_irq(hw_irq);
> atomic_inc(&link->irq_available);

\
 
 \ /
  Last update: 2023-11-20 13:59    [W:0.047 / U:0.696 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site