lkml.org 
[lkml]   [2023]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 1/1] dt-bindings: pwm: ti,pwm-omap-dmtimer: Update binding for yaml
* Uwe Kleine-König <u.kleine-koenig@pengutronix.de> [231114 10:36]:
> Hello,
>
> On Tue, Nov 14, 2023 at 10:27:06AM +0200, Tony Lindgren wrote:
> > + ti,timers:
> > + description: Timer instance phandle for the PWM
> > + $ref: /schemas/types.yaml#/definitions/phandle
> > +
> > + ti,prescaler:
> > + description: |
> > + Legacy clock prescaler for timer. The timer counter is prescaled
> > + with 2^n where n is the prescaler.
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + enum: [ 0, 1, 2, 3, 4, 5, 6, 7 ]
> > + deprecated: true
> > +
> > + ti,clock-source:
> > + description: |
> > + Legacy clock for timer, please use assigned-clocks instead.
> > + 0x00 - high-frequency system clock (timer_sys_ck)
> > + 0x01 - 32-kHz always-on clock (timer_32k_ck)
> > + 0x02 - external clock (timer_ext_ck, OMAP2 only)
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + enum: [ 0, 1, 2 ]
> > + deprecated: true
>
> Someone could collect some bonus points by converting these:
>
> $ git grep ti,clock-source arch/arm/boot
> arch/arm/boot/dts/ti/omap/am335x-guardian.dts: ti,clock-source = <0x01>;
> arch/arm/boot/dts/ti/omap/am3517-evm.dts: ti,clock-source = <0x01>;
> arch/arm/boot/dts/ti/omap/logicpd-torpedo-baseboard.dtsi: ti,clock-source = <0x01>;
> arch/arm/boot/dts/ti/omap/motorola-mapphone-common.dtsi: ti,clock-source = <0x01>;
> arch/arm/boot/dts/ti/omap/motorola-mapphone-common.dtsi: ti,clock-source = <0x01>;
> arch/arm/boot/dts/ti/omap/omap3-gta04.dtsi: ti,clock-source = <0x01>;
> arch/arm/boot/dts/ti/omap/omap3-n900.dts: ti,clock-source = <0x00>; /* timer_sys_ck */
>
> (I verified, this are all about this binding.)

Agreed, we should update all those.

> otherwise LGTM:
>
> Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>
> Should this go via the pwm tree or via some arm or omap or dt tree?

Please take this via the pwm tree, there are no dependencies.

Regards,

Tony

\
 
 \ /
  Last update: 2023-11-20 13:59    [W:0.037 / U:0.868 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site