lkml.org 
[lkml]   [2023]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/6] usb: cdns3-ti: add suspend/resume procedures for J7200
    Hello,

    On Mon Nov 13, 2023 at 4:39 PM CET, Gregory CLEMENT wrote:
    > > diff --git a/drivers/usb/cdns3/cdns3-ti.c b/drivers/usb/cdns3/cdns3-ti.c
    > > index c331bcd2faeb..50b38c4b9c87 100644
    > > --- a/drivers/usb/cdns3/cdns3-ti.c
    > > +++ b/drivers/usb/cdns3/cdns3-ti.c
    > > @@ -197,6 +197,50 @@ static int cdns_ti_probe(struct platform_device *pdev)
    > > return error;
    > > }
    > >
    > > +#ifdef CONFIG_PM
    > > +
    > > +static int cdns_ti_suspend(struct device *dev)
    > > +{
    > > + struct cdns_ti *data = dev_get_drvdata(dev);
    > > +
    > > + if (!of_device_is_compatible(dev_of_node(dev), "ti,j7200-usb"))
    > > + return 0;
    >
    > Just a small remark:
    >
    > What about adding a boolean in the cdns_ti struct for taking care of
    > it ? Then you will go through the device tree only during probe. Moreover
    > if this behaviour is needed for more compatible we can just add them in
    > the probe too.

    Will do. The hardest part will be to pick a good name.

    > Besides this you still can add my
    >
    > Reviewed-by: Gregory CLEMENT <gregory.clement@bootlin.com>

    Thanks for the review.

    --
    Théo Lebrun, Bootlin
    Embedded Linux and Kernel engineering
    https://bootlin.com

    \
     
     \ /
      Last update: 2023-11-20 13:58    [W:3.242 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site