Messages in this thread | | | From | Marco Elver <> | Date | Tue, 14 Nov 2023 12:00:49 +0100 | Subject | Re: [PATCH] kasan: default to inline instrumentation |
| |
On Thu, 9 Nov 2023 at 22:08, Andrey Konovalov <andreyknvl@gmail.com> wrote: > > On Thu, Nov 9, 2023 at 4:51 PM Paul Heidekrüger > <paul.heidekrueger@tum.de> wrote: > > > > KASan inline instrumentation can yield up to a 2x performance gain at > > the cost of a larger binary. > > > > Make inline instrumentation the default, as suggested in the bug report > > below. > > > > When an architecture does not support inline instrumentation, it should > > set ARCH_DISABLE_KASAN_INLINE, as done by PowerPC, for instance. > > > > CC: Dmitry Vyukov <dvyukov@google.com> > > Reported-by: Andrey Konovalov <andreyknvl@gmail.com> > > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=203495 > > Signed-off-by: Paul Heidekrüger <paul.heidekrueger@tum.de> > > --- > > lib/Kconfig.kasan | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/lib/Kconfig.kasan b/lib/Kconfig.kasan > > index fdca89c05745..935eda08b1e1 100644 > > --- a/lib/Kconfig.kasan > > +++ b/lib/Kconfig.kasan > > @@ -134,7 +134,7 @@ endchoice > > choice > > prompt "Instrumentation type" > > depends on KASAN_GENERIC || KASAN_SW_TAGS > > - default KASAN_OUTLINE > > + default KASAN_INLINE if !ARCH_DISABLE_KASAN_INLINE > > > > config KASAN_OUTLINE > > bool "Outline instrumentation" > > -- > > 2.40.1 > > > > Acked-by: Andrey Konovalov <andreyknvl@gmail.com> > > Thank you for taking care of this!
Reviewed-by: Marco Elver <elver@google.com>
+Cc Andrew (get_maintainers.pl doesn't add Andrew automatically for KASAN sources in lib/)
Thanks, -- Marco
| |