lkml.org 
[lkml]   [2023]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH V6 2/4] dt-bindings: clock: add Amlogic C3 peripherals clock controller bindings
From
Hi Krzysztof,
Thanks for your reply.

On 2023/11/10 21:24, Krzysztof Kozlowski wrote:
> [ EXTERNAL EMAIL ]
>
> On 06/11/2023 09:55, Xianwei Zhao wrote:
>> @@ -0,0 +1,237 @@
>
> A nit, subject: drop second/last, redundant "bindings". The
> "dt-bindings" prefix is already stating that these are bindings.
>
Will delete redundant "bindings" next version.
>> +/* SPDX-License-Identifier: (GPL-2.0-only OR MIT) */
>> +/*
>> + * Copyright (c) 2023 Amlogic, Inc. All rights reserved.
>> + * Author: Chuan Liu <chuan.liu@amlogic.com>
>> + */
>> +
>> +#ifndef _DT_BINDINGS_CLOCK_AMLOGIC_C3_PERIPHERALS_CLKC_H
>> +#define _DT_BINDINGS_CLOCK_AMLOGIC_C3_PERIPHERALS_CLKC_H
>> +
>> +#define CLKID_PLL_SRC 0
>> +#define CLKID_MCLK_PLL_SRC 1
>> +#define CLKID_DDR_PLL_SRC 2
>> +#define CLKID_DDR_PHY_SRC 3
>
> Fix the indentation. In all other patchses as well.
>
Will do
> Best regards,
> Krzysztof
>

\
 
 \ /
  Last update: 2023-11-20 13:58    [W:0.117 / U:0.788 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site