lkml.org 
[lkml]   [2023]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC v6 0/8] DRM scheduling cgroup controller
Hello,

From cgroup POV, it generally looks fine to me. As before, I'm really
curious whether this is something other non-intel drivers can get behind.
Just one nit.

On Tue, Oct 24, 2023 at 05:07:19PM +0100, Tvrtko Ursulin wrote:
> * Allowing per DRM card configuration and queries is deliberatly left out but
> it is compatible in principle with the current proposal.
>
> Where today we have, for drm.weight:
>
> 100
>
> We can later extend with:
>
> 100
> card0 80
> card1 20
>
> Similarly for drm.stat:
>
> usage_usec 1000
> card0.usage_usec 500
> card1.usage_usec 500

These dont't match what blkcg is doing. Please use nested keyed format
instead.

Thanks.

--
tejun

\
 
 \ /
  Last update: 2023-11-20 13:57    [W:1.400 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site