Messages in this thread | ![/](/images/icornerl.gif) | | Date | Sun, 12 Nov 2023 09:45:24 +0000 | From | Simon Horman <> | Subject | Re: [PATCH net,v4, 1/3] hv_netvsc: fix race of netvsc and VF register_netdevice |
| |
On Fri, Nov 10, 2023 at 06:38:58AM -0800, Haiyang Zhang wrote: > The rtnl lock also needs to be held before rndis_filter_device_add() > which advertises nvsp_2_vsc_capability / sriov bit, and triggers > VF NIC offering and registering. If VF NIC finished register_netdev() > earlier it may cause name based config failure. > > To fix this issue, move the call to rtnl_lock() before > rndis_filter_device_add(), so VF will be registered later than netvsc > / synthetic NIC, and gets a name numbered (ethX) after netvsc. > > Cc: stable@vger.kernel.org > Fixes: e04e7a7bbd4b ("hv_netvsc: Fix a deadlock by getting rtnl lock earlier in netvsc_probe()") > Reported-by: Dexuan Cui <decui@microsoft.com> > Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com> > Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
| ![\](/images/icornerr.gif) |