lkml.org 
[lkml]   [2023]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] ACPI: custom_method: fix a possible memory leak
On Sat, Nov 11, 2023 at 2:25 PM shiqiang.deng
<shiqiang.deng213@gmail.com> wrote:
>
> In the cm_write() function, memory is allocated,
> and at the end of the function when uncopied_bytes is 0,
> the memory is freed. If uncopied_bytes is not equal to 0,
> a memory leak occurs.
>
> Signed-off-by: shiqiang.deng <shiqiang.deng213@gmail.com>
> ---
> drivers/acpi/custom_method.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/acpi/custom_method.c b/drivers/acpi/custom_method.c
> index d39a9b474727..5103c7c3a6ce 100644
> --- a/drivers/acpi/custom_method.c
> +++ b/drivers/acpi/custom_method.c
> @@ -77,6 +77,9 @@ static ssize_t cm_write(struct file *file, const char __user *user_buf,
> if (ACPI_FAILURE(status))
> return -EINVAL;
> add_taint(TAINT_OVERRIDDEN_ACPI_TABLE, LOCKDEP_NOW_UNRELIABLE);
> + } else {
> + kfree(buf);
> + buf = NULL;
> }
>
> return count;
> --

That was discussed in the past and I still would rather drop this I/F
completely instead of patching it for minor issues.

\
 
 \ /
  Last update: 2023-11-20 13:57    [W:0.045 / U:1.924 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site