Messages in this thread | | | From | Niklas Cassel <> | Subject | Re: [PATCH v2] ata: sata_mv: aspeed: fix value check in mv_platform_probe() | Date | Mon, 9 Oct 2023 14:22:37 +0000 |
| |
On Mon, Oct 09, 2023 at 08:49:55PM +0800, Ma Ke wrote: > In mv_platform_probe(), check the return value of clk_prepare_enable() > and return the error code if clk_prepare_enable() returns an > unexpected value. > > Signed-off-by: Ma Ke <make_ruc2021@163.com> > --- > drivers/ata/sata_mv.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c > index 45e48d653c60..df3a02e7a50b 100644 > --- a/drivers/ata/sata_mv.c > +++ b/drivers/ata/sata_mv.c > @@ -4125,8 +4125,10 @@ static int mv_platform_probe(struct platform_device *pdev) > hpriv->clk = clk_get(&pdev->dev, NULL); > if (IS_ERR(hpriv->clk)) > dev_notice(&pdev->dev, "cannot get optional clkdev\n"); > - else > - clk_prepare_enable(hpriv->clk); > + else { > + rc = clk_prepare_enable(hpriv->clk); > + goto err; > + } > > for (port = 0; port < n_ports; port++) { > char port_number[16]; > -- > 2.37.2 >
Reviewed-by: Niklas Cassel <niklas.cassel@wdc.com>
| |