Messages in this thread | | | Date | Mon, 9 Oct 2023 08:35:22 +0200 | From | Maciej Wieczór-Retman <> | Subject | Re: [PATCH v4 4/4] Documentation/x86: Document resctrl's new sparse_masks |
| |
Hi, thanks for reviewing the series!
On 2023-10-06 at 15:42:15 -0500, Moger, Babu wrote: >Hi Maciej, > >My last comment didn't make it to lkml. Could be my mail server problem. >Commenting again. > >On 10/5/2023 3:15 AM, Maciej Wieczor-Retman wrote: >> From: Fenghua Yu <fenghua.yu@intel.com> >> >> The documentation mentions that non-contiguous bit masks are not >> supported in Intel Cache Allocation Technology (CAT). >> >> Update the documentation on how to determine if sparse bit masks are >> allowed in L2 and L3 CAT. >> >> Mention the file with feature support information is located in >> the /sys/fs/resctrl/info/{resource}/ directories and enumerate what >> are the possible outputs on file read operation. > >This last paragraph is not clear. All the information is already in the >documentation.
Right, I guess that paragraph does mirror patch contents a bit too much. I'll remove it and repost it.
>You can drop this paragraph. First two paragraphs are fine. > >> >> Signed-off-by: Fenghua Yu <fenghua.yu@intel.com> >> Signed-off-by: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com> >> Tested-by: Peter Newman <peternewman@google.com> >> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> >> Reviewed-by: Peter Newman <peternewman@google.com> >> Reviewed-by: Reinette Chatre <reinette.chatre@intel.com> > >Otherwise patch looks fine. > >Reviewed-by: Babu Moger <babu.moger@amd.com> > >Thanks > >Babu >
-- Kind regards Maciej Wieczór-Retman
| |