Messages in this thread | | | Date | Mon, 9 Oct 2023 16:20:55 +0300 | From | Dmitry Rokosov <> | Subject | Re: [PATCH v1 05/11] leds: aw200xx: calculate dts property display_rows in driver |
| |
On Fri, Oct 06, 2023 at 08:59:46PM +0300, Andy Shevchenko wrote: > On Fri, Oct 6, 2023 at 7:05 PM Dmitry Rokosov > <ddrokosov@salutedevices.com> wrote: > > > > From: George Stark <gnstark@salutedevices.com> > > > > Get rid of device tree property "awinic,display-rows" and calculate it > > in driver using led definition nodes. display-row actually means number > > of current switches and depends on how leds are connected to the device. > > So, how do we know that there will be no regressions on the systems > where this property is used in production?
In the production boards, developers should set up the display-rows correctly; otherwise, the AW200XX LED controller will not function properly. In the new implementation, we calculate display-rows automatically, and I assume that the value will remain unchanged.
> > + if (max_source < source) > > + max_source = source; > > max() (will need minmax.h)?
Correct, I will fix it in the v2.
-- Thank you, Dmitry
| |