lkml.org 
[lkml]   [2023]   [Oct]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v2 17/19] kasan: remove atomic accesses to stack ring entries
    On Wed, Sep 13, 2023 at 7:17 PM <andrey.konovalov@linux.dev> wrote:
    >
    > From: Andrey Konovalov <andreyknvl@google.com>
    >
    > Remove the atomic accesses to entry fields in save_stack_info and
    > kasan_complete_mode_report_info for tag-based KASAN modes.
    >
    > These atomics are not required, as the read/write lock prevents the
    > entries from being read (in kasan_complete_mode_report_info) while being
    > written (in save_stack_info) and the try_cmpxchg prevents the same entry
    > from being rewritten (in save_stack_info) in the unlikely case of wrapping
    > during writing.

    Given that you removed all atomic accesses, it should be fine to
    remove the inclusion of atomic.h as well.

    > Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
    Reviewed-by: Alexander Potapenko <glider@google.com>

    \
     
     \ /
      Last update: 2023-10-09 14:07    [W:4.384 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site