Messages in this thread | | | From | Miguel Ojeda <> | Date | Mon, 9 Oct 2023 12:49:21 +0200 | Subject | Re: [PATCH] rust: macros: update 'paste!' macro to accept string literals |
| |
On Mon, Oct 9, 2023 at 5:04 AM Trevor Gross <tmgross@umich.edu> wrote: > > Good point, thanks! I'll add that if there is a v2 (or Miguel can > probably add it if not)
Yes, I add them myself when I notice they are missing (e.g. most recently 2 of the ones in `rust-fixes`), but patches should definitely come with the `Fixes: ` tag themselves, i.e. it should be the exceptional case.
However, is this actually a fix? The title and commit message make it sound like it is a new feature rather than a fix. And the docs of the macro says literals are not supported, right?
So this probably needs to update those docs too (and ideally add an example with the newly supported construct too). Or am I misunderstanding?
Cheers, Miguel
| |