lkml.org 
[lkml]   [2023]   [Oct]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v4 6/8] selftests/kvm: Replace attribute with macro
    Date
    The __printf() macro is used in many tools in the linux kernel to
    validate the format specifiers in functions that use printf. The kvm
    selftest uses it without putting it in a macro definition while it
    also imports the kselftests.h header.

    Use __printf() from kselftests.h instead of the full attribute.

    Signed-off-by: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>
    ---
    Changelog v2:
    - Reword patch message.
    - Use __printf() on test_assert().

    tools/testing/selftests/kvm/include/test_util.h | 8 ++++----
    1 file changed, 4 insertions(+), 4 deletions(-)

    diff --git a/tools/testing/selftests/kvm/include/test_util.h b/tools/testing/selftests/kvm/include/test_util.h
    index 7e614adc6cf4..8e5f413a593d 100644
    --- a/tools/testing/selftests/kvm/include/test_util.h
    +++ b/tools/testing/selftests/kvm/include/test_util.h
    @@ -33,7 +33,7 @@ static inline int _no_printf(const char *format, ...) { return 0; }
    #define pr_info(...) _no_printf(__VA_ARGS__)
    #endif

    -void print_skip(const char *fmt, ...) __attribute__((format(printf, 1, 2)));
    +void __printf(1, 2) print_skip(const char *fmt, ...);
    #define __TEST_REQUIRE(f, fmt, ...) \
    do { \
    if (!(f)) \
    @@ -46,9 +46,9 @@ ssize_t test_write(int fd, const void *buf, size_t count);
    ssize_t test_read(int fd, void *buf, size_t count);
    int test_seq_read(const char *path, char **bufp, size_t *sizep);

    -void test_assert(bool exp, const char *exp_str,
    - const char *file, unsigned int line, const char *fmt, ...)
    - __attribute__((format(printf, 5, 6)));
    +void __printf(5, 6) test_assert(bool exp, const char *exp_str,
    + const char *file, unsigned int line,
    + const char *fmt, ...);

    #define TEST_ASSERT(e, fmt, ...) \
    test_assert((e), #e, __FILE__, __LINE__, fmt, ##__VA_ARGS__)
    --
    2.42.0
    \
     
     \ /
      Last update: 2023-10-09 12:33    [W:7.357 / U:0.516 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site