Messages in this thread | | | Date | Mon, 9 Oct 2023 08:04:25 +0200 | Subject | Re: [PATCH] ASoC: ti: ams-delta: Fix cx81801_receive() argument types | From | Jiri Slaby <> |
| |
On 07. 10. 23, 23:38, Janusz Krzysztofik wrote: > Since types of arguments accepted by tty_ldis_ops::receive_buf() have > changed, the driver no longer builds. > > .../linux/sound/soc/ti/ams-delta.c:403:24: error: initialization of 'void (*)(struct tty_struct *, const u8 *, const u8 *, size_t)' {aka 'void (*)(struct tty_struct *, const unsigned char *, const unsigned char *, unsigned int)'} from incompatible pointer type 'void (*)(struct tty_struct *, const u8 *, const char *, int)' {aka 'void (*)(struct tty_struct *, const unsigned char *, const char *, int)'} [-Werror=incompatible-pointer-types] > 403 | .receive_buf = cx81801_receive, > > Fix it. > > Fixes: e8161447bb0c ("tty: make tty_ldisc_ops::*buf*() hooks operate on size_t") > Fixes: 892bc209f250 ("tty: use u8 for flags") > Signed-off-by: Janusz Krzysztofik <jmkrzyszt@gmail.com>
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
> --- > sound/soc/ti/ams-delta.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sound/soc/ti/ams-delta.c b/sound/soc/ti/ams-delta.c > index 371943350fdf..666057d50ea0 100644 > --- a/sound/soc/ti/ams-delta.c > +++ b/sound/soc/ti/ams-delta.c > @@ -336,8 +336,8 @@ static void cx81801_hangup(struct tty_struct *tty) > } > > /* Line discipline .receive_buf() */ > -static void cx81801_receive(struct tty_struct *tty, const u8 *cp, > - const char *fp, int count) > +static void cx81801_receive(struct tty_struct *tty, const u8 *cp, const u8 *fp, > + size_t count)
Thanks for fixing this. Funny enough that I managed to switch cp, but not the others. Yeah, there was a lot to overlook in those big changes.
regards, -- js suse labs
| |